Add a feature flag for tty support #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled by default but can be disabled explicitly. Address support for wasm-wasi and unsafe concerns. Signed-off-by: roee88 <roee88@gmail.com>
|
Thanks a lot for your contribution :)! You can ignore the failing coverage tests. The code looks fine. |
Nukesor
requested changes
Aug 11, 2021
Signed-off-by: roee88 <roee88@gmail.com>
|
Well, this looks good to me :) If you don't mind, I'll mention you in the changelog, once this is merged. |
Nukesor
approved these changes
Aug 11, 2021
|
New version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled by default but can be disabled explicitly.
#![forbid(unsafe_code)]#42 Prettytable is unmaintained. Change to comfy-table jorgecarleitao/arrow2#251 (comment)