Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinVerDefaultPreReleasePhase is deprecated and will be removed #1379

Open
henry-js opened this issue May 15, 2024 · 0 comments
Open

MinVerDefaultPreReleasePhase is deprecated and will be removed #1379

henry-js opened this issue May 15, 2024 · 0 comments
Labels

Comments

@henry-js
Copy link

Usage Information

8.0.0/8.0.204/8.0/Windows

Description

When using MinVerSettings.SetDefaultPreReleasePhase an error is logged by minver-cli because that command option is now deprecated: https://github.com/adamralph/minver/blob/38681c8f283e109f4b2e0d212d761bd828d16802/minver-cli/Program.cs#L81

Reproduction Steps

Call the minver cli in a Target:

    [MinVer] readonly MinVer MinVer;
    Target PrintVersion => _ => _
        .Executes(() =>
        {
            MinVerTasks.MinVer(_ => _
                .SetMinimumMajorMinor("1.0")
                .SetDefaultPreReleasePhase("preview.0")
            );
            Log.Information(MinVer.Version);
        });

Expected Behavior

Should not get an error message

Actual Behavior

[ERR] PrintVersion: MinVer: warning : MinVerDefaultPreReleasePhase is deprecated and will be removed in the next major version. Use MinVerDefaultPreReleaseIdentifiers instead, with an additional "0" identifier. For example, if you are setting MinVerDefaultPreReleasePhase to "preview", set MinVerDefaultPreReleaseIdentifiers to "preview.0" instead.

Regression?

No response

Known Workarounds

No response

Could you help with a pull-request?

Yes

@henry-js henry-js added the bug label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant