Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of ZeroizableByteArray #98

Closed
fjarri opened this issue Aug 1, 2022 · 1 comment
Closed

Get rid of ZeroizableByteArray #98

fjarri opened this issue Aug 1, 2022 · 1 comment
Labels
API Related to public API blocked Blocked by a third-party library

Comments

@fjarri
Copy link
Collaborator

fjarri commented Aug 1, 2022

Currently we have a ZeroizableByteArray which is a thin wrapper around GenericArray. GenericArray does not currently support zeroization (see the PR at fizyk20/generic-array#126), and we need to put it in a SecretBox to return from SerializableToSecretArray::to_secret_array(). Two ways to fix this issue:

  • Switch to using Rust arrays. This is blocked by const generics not supporting all the required functionality yet (e.g. using an associated constant from a trait in a const generic trait method, or statically-typed array splitting).
  • Use GenericArray when the PR above is merged.

Given how slow the development of generic-array goes recently, there's no way to tell which comes first.

@fjarri fjarri added API Related to public API blocked Blocked by a third-party library labels Aug 1, 2022
@fjarri
Copy link
Collaborator Author

fjarri commented Aug 3, 2022

fizyk20/generic-array#126 was merged, so ZeroizableByteArray can be cut out of #97

@fjarri fjarri closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to public API blocked Blocked by a third-party library
Projects
None yet
Development

No branches or pull requests

1 participant