Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to release 5.2.0 #793

Open
Romfos opened this issue Apr 20, 2024 · 6 comments
Open

Need to release 5.2.0 #793

Romfos opened this issue Apr 20, 2024 · 6 comments

Comments

@Romfos
Copy link
Contributor

Romfos commented Apr 20, 2024

Hi,

v5.2.0 was released but nuget still has 5.1.0 as latest

please, upload 5.2.0 to nuget

Thank you

@dtchepak @alexandrnikitin

@Romfos Romfos changed the title Need to release 5.1.0 Need to release 5.2.0 Apr 20, 2024
@dtchepak
Copy link
Member

Hi @Romfos ,

We're just trying to get the release build sorted after the appveyor move. (#791)

Having some laptop issues at the moment but will try to sort it as soon as I can

@nesc58
Copy link

nesc58 commented Apr 22, 2024

Hi,
is there any news on this issue?
The nuget package is still missing on https://www.nuget.org/packages/NSubstitute

Thanks

@304NotModified
Copy link
Contributor

Is this the new release GitHub action?

https://github.com/nsubstitute/NSubstitute/actions/runs/8763686910/workflow

  • its not in the main branch (or any branch?)
  • the yaml is invalid

But not sure if this is the correct GitHub action

@dtchepak
Copy link
Member

I started to look at this (#791 (comment), haven't used GitHub actions before 😅 ) but my laptop decided to die before I could get anything working. I'll try to get access to a non-work machine to sort this as soon as I can. 🙇

Is there something in particular you need from this release? 5.1.0 should still be ok for now?

@304NotModified
Copy link
Contributor

304NotModified commented Apr 23, 2024

https://github.com/dtchepak/NSubstitute/blob/release-ci/.github/workflows/release_build.yml

Looks as a good start :)

Please note that you should also push the nupkg and the snupkg for source link (although nuget will do that automatically nowadays. See https://learn.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg)

(If we're unsure, maybe we should test with beta packages)

@dtchepak
Copy link
Member

@304NotModified I think I've got it working: #797

Could you please take a look for me? 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants