Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be a good idea to return a reference to the file instead of the file path? #64

Closed
quantuminformation opened this issue Jun 20, 2017 · 6 comments
Assignees
Labels

Comments

@quantuminformation
Copy link

Love this lib btw!

@nspragg
Copy link
Owner

nspragg commented Jun 22, 2017

@quantuminformation - thanks!

Do you mean return the filename instead of a fully qualified path? Or return a file object?

@nspragg nspragg self-assigned this Jun 22, 2017
@quantuminformation
Copy link
Author

The file object.

My use case is microsoft/TypeScript#16577 (comment)

where I had to read the file separately.

@nspragg
Copy link
Owner

nspragg commented Jul 3, 2017

Interesting idea but for the time being I'll keep it simple and return the path as a string. That way, the user can either process an array of string (paths) or map over the results to convert to the appropriate type.

@nspragg
Copy link
Owner

nspragg commented Jan 28, 2019

Due to be released in v1.17.0

@quantuminformation
Copy link
Author

gg

@nspragg
Copy link
Owner

nspragg commented Jan 28, 2019

@quantuminformation - support added for including file stats in v1.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants