Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port getnativecontracts change #3430

Closed
roman-khimov opened this issue May 3, 2024 · 0 comments
Closed

Port getnativecontracts change #3430

roman-khimov opened this issue May 3, 2024 · 0 comments
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U2 Seriously planned
Milestone
v0.106.0

Comments

@roman-khimov
Copy link
Member

neo-project/neo-modules#900
@roman-khimov roman-khimov added I3 Minimal impact enhancement Improving existing functionality U2 Seriously planned S3 Minimally significant labels May 3, 2024
@roman-khimov roman-khimov added this to the v0.106.0 milestone May 3, 2024
roman-khimov added a commit that referenced this issue May 15, 2024
@roman-khimov
state: drop NativeContract and ContractBase, fix #3430
9ae5456 
This is somewhat deeper than its C# counterpart, but the essence is the same,
we return proper []state.Contract from getnativecontracts RPC and thus many of
older types are no longer needed. Some hacks around UpdateCounter are removed
as well.

The change can potentially affect third-party apps, but should be easy to
adopt.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
AnnaShaleva added a commit that referenced this issue May 17, 2024
@AnnaShaleva
Merge pull request #3439 from nspcc-dev/getnativecontracts
647b8c7 
state: drop NativeContract, fix #3430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U2 Seriously planned
Projects
None yet
Milestone
v0.106.0
Development

No branches or pull requests
1 participant
@roman-khimov