Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --vub-increment option for CLI commands #3373

Open
AnnaShaleva opened this issue Mar 25, 2024 · 0 comments
Open

Implement --vub-increment option for CLI commands #3373

AnnaShaleva opened this issue Mar 25, 2024 · 0 comments
Labels
cli Command line interface enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U4 Nothing urgent
Milestone

Comments

@AnnaShaleva
Copy link
Member

Is your feature request related to a problem? Please describe.

User may need to set some custom VUB value for transactions that are constructed via CLI.

Describe the solution you'd like

We need to add a CLI option that allows to override the default VUB transaction value set by txctx:

tx.ValidUntilBlock += uint32((waitTime.Milliseconds() / int64(ver.Protocol.MillisecondsPerBlock))) + 1

Also, manually-signed transactions may also consider to handle this option:

tx.ValidUntilBlock += (ver.Protocol.MaxValidUntilBlockIncrement - uint32(ver.Protocol.ValidatorsCount)) - 2

Ref. #3343.

@AnnaShaleva AnnaShaleva added I3 Minimal impact U4 Nothing urgent enhancement Improving existing functionality cli Command line interface S3 Minimally significant labels Mar 25, 2024
@AnnaShaleva AnnaShaleva added this to the v0.107.0 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Command line interface enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

1 participant