We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some tokens are limited in quantity. For example, NEO <= 100KK according to docs. This limit is missing in https://pkg.go.dev/github.com/nspcc-dev/neo-go/pkg/rpcclient/neo (in particular https://pkg.go.dev/github.com/nspcc-dev/neo-go@v0.104.0/pkg/rpcclient/neptoken#Base.BalanceOf). This complicates code checks and optimization like using fixed bitsize math instead of big integers if possible
mention limits in BalanceOf methods' docs
BalanceOf
do not touch
* inspired by nspcc-dev/neofs-node#2683 (comment)
The text was updated successfully, but these errors were encountered:
Technically, you have NEP-17 totalSupply to get it and that's the standard NEP-17 way. At the same time it's well-known for NEO and won't change.
totalSupply
Sorry, something went wrong.
@roman-khimov, i thought about checking limits against totalSupply but this seems an overhead to me when it returns static value like for NEO
No branches or pull requests
Is your feature request related to a problem? Please describe.
some tokens are limited in quantity. For example, NEO <= 100KK according to docs. This limit is missing in https://pkg.go.dev/github.com/nspcc-dev/neo-go/pkg/rpcclient/neo (in particular https://pkg.go.dev/github.com/nspcc-dev/neo-go@v0.104.0/pkg/rpcclient/neptoken#Base.BalanceOf). This complicates code checks and optimization like using fixed bitsize math instead of big integers if possible
Describe the solution you'd like
mention limits in
BalanceOf
methods' docsDescribe alternatives you've considered
do not touch
Additional context
* inspired by nspcc-dev/neofs-node#2683 (comment)
The text was updated successfully, but these errors were encountered: