Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GAS refund attribute #2845

Open
roman-khimov opened this issue Dec 15, 2022 · 2 comments · May be fixed by #2905
Open

Implement GAS refund attribute #2845

roman-khimov opened this issue Dec 15, 2022 · 2 comments · May be fixed by #2905
Labels
feature Completely new functionality I1 High impact S2 Regular significance U4 Nothing urgent

Comments

@roman-khimov
Copy link
Member

See neo-project/neo#2806 (comment). It's pretty easy to do with NeoGo, we have all of the appropriate data immediately. If it works (and it should, only contract addresses are somewhat of a problem, but it's a known one and it can be worked around), it can be proposed as a proper protocol change for 3.7.0/3.8.0.
ZhangTao1596 added a commit to ZhangTao1596/neo-go that referenced this issue Jan 31, 2023
@ZhangTao1596
core: fix nspcc-dev#2845 system fee refund attribute
69b25d2
@ZhangTao1596
Copy link
Contributor

ZhangTao1596 commented Jan 31, 2023 •
edited

An initial version is here https://github.com/ZhangTao1596/neo-go/tree/system-fee-refund. I will optimize and test tomorrow.

@roman-khimov
Copy link
Member Author

There is a race between dao.GetTxExecResult() in getTxCosumed() and storeBlock() saving this data asynchronously (see a goroutine there), some additional mechanism is needed probably to have this data in the context of PostPersist (we technically have it, but it may not be yet in DAO).

ZhangTao1596 added a commit to ZhangTao1596/neo-go that referenced this issue Feb 9, 2023
@ZhangTao1596
core: fix nspcc-dev#2845 system fee refund attribute
1994f4b
ZhangTao1596 added a commit to ZhangTao1596/neo-go that referenced this issue Feb 9, 2023
@ZhangTao1596
core: fix nspcc-dev#2845 system fee refund attribute
18b7900
@ZhangTao1596 ZhangTao1596 linked a pull request Feb 9, 2023 that will close this issue
Open
ZhangTao1596 added a commit to ZhangTao1596/neo-go that referenced this issue Feb 13, 2023
@ZhangTao1596
core: fix nspcc-dev#2845 Roman's feedback
238f254
ZhangTao1596 added a commit to ZhangTao1596/neo-go that referenced this issue Feb 15, 2023
@ZhangTao1596
core: fix nspcc-dev#2845 attribute type string
d8bcb25
ZhangTao1596 added a commit to ZhangTao1596/neo-go that referenced this issue Mar 1, 2023
@ZhangTao1596
core: anna's feedback (fix nspcc-dev#2845)
f9fb12a
ZhangTao1596 added a commit to ZhangTao1596/neo-go that referenced this issue Mar 2, 2023
@ZhangTao1596
core: system fee refund ut (fix nspcc-dev#2845)
1cb4dda
@roman-khimov roman-khimov added feature Completely new functionality I1 High impact U4 Nothing urgent S2 Regular significance labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Completely new functionality I1 High impact S2 Regular significance U4 Nothing urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add system fee refundable attribute ZhangTao1596/neo-go
2 participants
@roman-khimov @ZhangTao1596