Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency doesn't trigger error #9276

Closed
mainstreet-droe opened this issue Mar 10, 2022 · 2 comments
Closed

Circular dependency doesn't trigger error #9276

mainstreet-droe opened this issue Mar 10, 2022 · 2 comments

Comments

@mainstreet-droe
Copy link

Current Behavior

Accidentally adding a circular dependency causes the build to silently fail

Expected Behavior

Build failure with circular dependency error

Steps to Reproduce

  1. Checkout nx circular depdenency bug nx-examples#192
  2. yarn install
  3. yarn nx build app1
  4. Observe previous command succeeded and no dist directory is created

Environment

Node : 16.14.0
OS : darwin x64
yarn : 1.22.17

nx : 13.8.1
@nrwl/angular : 13.8.1
@nrwl/cli : 13.8.1
@nrwl/cypress : 13.8.1
@nrwl/detox : undefined
@nrwl/devkit : 13.8.1
@nrwl/eslint-plugin-nx : 13.8.1
@nrwl/express : undefined
@nrwl/jest : 13.8.1
@nrwl/js : 13.8.1
@nrwl/linter : 13.8.1
@nrwl/nest : undefined
@nrwl/next : undefined
@nrwl/node : undefined
@nrwl/nx-cloud : 13.1.4
@nrwl/react : 13.8.1
@nrwl/react-native : undefined
@nrwl/schematics : undefined
@nrwl/storybook : 13.8.1
@nrwl/tao : 13.8.1
@nrwl/web : 13.8.1
@nrwl/workspace : 13.8.1
typescript : 4.5.5
rxjs : 6.5.5

Community plugins:
@angular/animations: 13.2.2
@angular/common: 13.2.2
@angular/compiler: 13.2.2
@angular/core: 13.2.2
@angular/forms: 13.2.2
@angular/platform-browser: 13.2.2
@angular/platform-browser-dynamic: 13.2.2
@angular/router: 13.2.2
@ngrx/component-store: 13.0.1
@ngrx/effects: 13.0.1
@ngrx/entity: 13.0.1
@ngrx/router-store: 13.0.1
@ngrx/store: 13.0.1
@angular-devkit/build-angular: 13.2.3
@angular/cli: 13.2.3
@angular/compiler-cli: 13.2.2
@angular/language-service: 13.2.2
@ngrx/store-devtools: 13.0.1

@AgentEnder AgentEnder added the scope: core core nx functionality label Mar 11, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants