web: rollup executor invalid type-checking

[Hotell]

Current Behavior

@nrwl/web:rollup executor uses under the hood https://github.com/ezolenko/rollup-plugin-typescript2 TS plugin.

Now because this plugin doesn't work as expected ezolenko/rollup-plugin-typescript2#298 one may/will ship invalid code to consumers.

Expected Behavior

rollup executor @nrwl/web:rollup should properly run type-checking to be on par with raw tsc

Environment

yarn : 1.22.10
  
  nx : 13.4.6
  @nrwl/angular : undefined
  @nrwl/cli : 13.4.6
  @nrwl/cypress : 13.4.6
  @nrwl/devkit : 13.4.6
  @nrwl/eslint-plugin-nx : 13.4.6
  @nrwl/express : undefined
  @nrwl/jest : 13.4.6
  @nrwl/linter : 13.4.6
  @nrwl/nest : undefined
  @nrwl/next : undefined
  @nrwl/node : undefined
  @nrwl/nx-cloud : undefined
  @nrwl/react : 13.4.6
  @nrwl/react-native : undefined
  @nrwl/schematics : undefined
  @nrwl/tao : 13.4.6
  @nrwl/web : 13.4.6
  @nrwl/workspace : 13.4.6
  @nrwl/storybook : 13.4.6
  @nrwl/gatsby : undefined
  typescript : 4.4.4
  rxjs : 6.6.7

[Hotell]

NOTE: I tried to use official typescript rollup plugin - it type-checks correctly so maybe I'd reconsider to use that one for rollup executor (would be great to have some visibility why a non official plugin is being used ATM) .

[ronnetzer]

Hi @Hotell, any new regarding this one?
We've noticed that rollup-plugin-typescript2 has some performance issues compared to the official plugin which is significantly faster.

[github-actions]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

[Hotell]

The issue has been closed as fixed in that roll-up plugin repo, so executor deps need to be bumped. We went with our own implementation to unblock. Cheers

[StoneYaoTreelab]

The issue has been closed as fixed in that roll-up plugin repo, so executor deps need to be bumped. We went with our own implementation to unblock. Cheers

But even I migrate the nx to 15.0.0, the type check error still exist and the tsc type check is fine.

[jaysoo]

Fixed in 95a3bbf.

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.