fix(react): align component and e2e test generation #6535
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Right now if you generate a new React component it generates the welcome message in a "dasherized" name.
It doesn't make a lot of sense since the actual selector of the React component would be
TopicButton
and nottopic-button
. But apart from that, what happens when generating a Cypress storybook test is that the test right now is generated as follows:Basically it checks whether the name is the project name, rather than component name, thus the pre-generated e2e test fails. Which is bad.
Expected Behavior
This PR aligns the React component generator with the e2e test generator s.t. when just using code generation tests pass. Which should always be the case
To test
Related Issue(s)
Fixes #