feat(react): add fast refresh support for webpack 5 #6529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/6CSBWYDPfK4SaCpVeA7fwX4g4Uat [Deployment for 8b66c73 canceled] |
jaysoo
commented
Jul 28, 2021
| ); | ||
| const entryFiles: FileInfo[] = entrypoint | ||
| ?.getFiles() | ||
| ?.filter((f) => !f.endsWith('.hot-update.js')) |
There was a problem hiding this comment.
This is needed to avoid hot-update files from being included in generated HTML (which breaks).
jaysoo
force-pushed
the
webpack5-react-fast-refresh
branch
from
63e0b98
to
a6ee594
Compare
Nx Cloud ReportCI ran the following commands for commit 8b66c73. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
webpack5-react-fast-refresh
branch
from
a6ee594
to
6d6b303
Compare
jaysoo
force-pushed
the
webpack5-react-fast-refresh
branch
from
6d6b303
to
9bda250
Compare
jaysoo
force-pushed
the
webpack5-react-fast-refresh
branch
from
9bda250
to
793c475
Compare
jaysoo
force-pushed
the
webpack5-react-fast-refresh
branch
from
793c475
to
8b66c73
Compare
FrozenPandaz
approved these changes
Jul 29, 2021
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 29, 2021
ManojBahuguna
pushed a commit
to ManojBahuguna/nx
that referenced
this pull request
Sep 16, 2021
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables fast refresh for React and webpack 5.
Current Behavior
Upgrading to webpack 5 breaks fast refresh.
Expected Behavior
Upgrading to webpack 5 supports fast refresh
Related Issue(s)
Fixes #6506