Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(core): use isNpmProject and cleanup project graph utils #6522

Merged
merged 2 commits into from Jul 29, 2021

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Jul 27, 2021

Current Behavior

  • On several locations in the codebase we check whether project is an external npm package by checking the project's type. In project-graph there is already dedicated function for this - isNpmProject.
  • The normalize-nx-json is missing comments and code is a bit complex to read
  • The buildable-libs-utils in utils folder is unused. There is a duplicate in utilities that is used.

Expected Behavior

  • We should use dedicated function for checking whether project is an npm package
  • Normalize normalizeNxJson should be easy to read and should have comments to guide reader
  • Unused duplicate of buildable-libs-utils should be removed

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Jul 27, 2021
@vercel
Copy link

vercel bot commented Jul 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/AaCYUunG4EEsxBKtTj4VJjJU1p7e
✅ Preview: Canceled

[Deployment for 0761cf9 canceled]

@meeroslav meeroslav requested a review from vsavkin July 27, 2021 16:20
@@ -1,315 +0,0 @@
import { ProjectType } from '../core/project-graph';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep this file and the above file for backwards compatibility. Some people might still import from this path even though it's a deep import.

We can remove them in Nx v13.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll mark those functions then as deprecated

@FrozenPandaz FrozenPandaz merged commit 117ee93 into nrwl:master Jul 29, 2021
FrozenPandaz pushed a commit that referenced this pull request Jul 29, 2021
* cleanup(core): use isNpmProject and cleanup project graph utils

* chore(core): mark utils/buildable-libs-utils as deprecated
@meeroslav meeroslav deleted the chore/optimize-project-graph branch August 10, 2021 11:21
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
…#6522)

* cleanup(core): use isNpmProject and cleanup project graph utils

* chore(core): mark utils/buildable-libs-utils as deprecated
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality type: cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants