New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(core): use isNpmProject and cleanup project graph utils #6522
cleanup(core): use isNpmProject and cleanup project graph utils #6522
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/AaCYUunG4EEsxBKtTj4VJjJU1p7e [Deployment for 0761cf9 canceled] |
Nx Cloud ReportCI ran the following commands for commit 0761cf9. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
@@ -1,315 +0,0 @@ | |||
import { ProjectType } from '../core/project-graph'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep this file and the above file for backwards compatibility. Some people might still import from this path even though it's a deep import.
We can remove them in Nx v13.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll mark those functions then as deprecated
* cleanup(core): use isNpmProject and cleanup project graph utils * chore(core): mark utils/buildable-libs-utils as deprecated
…#6522) * cleanup(core): use isNpmProject and cleanup project graph utils * chore(core): mark utils/buildable-libs-utils as deprecated
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
project-graph
there is already dedicated function for this -isNpmProject
.normalize-nx-json
is missing comments and code is a bit complex to readbuildable-libs-utils
inutils
folder is unused. There is a duplicate inutilities
that is used.Expected Behavior
buildable-libs-utils
should be removedRelated Issue(s)
Fixes #