Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): handle moving to a subfolder which results in the same project name and normalize import path #6507

Merged
merged 1 commit into from Jul 26, 2021

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jul 26, 2021

Current Behavior

When moving an Angular project to a subfolder which results in the same project name to be generated (e.g. from my-project to my/project), the module gets incorrectly deleted and the path alias in the tsconfig.base.json gets changed even though the project name is the same. The latter issue is caused because when moving any project to a nested structure with no importPath provided, the auto-generated importPath uses the directory name (with /) instead of the project name.

Expected Behavior

Moving an Angular project should not delete the module file. Moving any project should correctly auto-generate the importPath.

Related Issue(s)

Fixes #6487

@leosvelperez leosvelperez self-assigned this Jul 26, 2021
@vercel
Copy link

vercel bot commented Jul 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/G2hHn4G25rwFFvuVqZVoYGnqoVLH
✅ Preview: https://nx-dev-git-fork-leosvelperez-fix-ng-move-generator-nrwl.vercel.app

@leosvelperez leosvelperez merged commit c6fee86 into nrwl:master Jul 26, 2021
@leosvelperez leosvelperez deleted the fix-ng-move-generator branch July 26, 2021 13:56
FrozenPandaz pushed a commit that referenced this pull request Jul 29, 2021
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NX move with publishable library has some unexpected results
1 participant