Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): allow run-commands to accept readyWhen for a single command #6496

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jul 23, 2021

Current Behavior

@nrwl/workspace:run-commands does not allow to use readyWhen with a single command. This was something that was kind of working before #6448, because we were able to bypass the restriction by using commands with a single command, but if you tried to use it with command it would error. This was inconsistent behavior and not in line with the docs. In #6448 the restriction was "corrected" to match the docs, but there's actually no reason to enforce that and limit that option to only multiple commands.

Expected Behavior

@nrwl/workspace:run-commands should allow using readyWhen with a single command. When running multiple commands, readyWhen can only be set if the parallel option is set to true.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Jul 23, 2021
@vercel
Copy link

vercel bot commented Jul 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/7FV7nkiT6LJyWaGjPh5nhFAizZAu
✅ Preview: https://nx-dev-git-fork-leosvelperez-run-commands-readywhen-476c51-nrwl.vercel.app

@leosvelperez leosvelperez merged commit 873e297 into nrwl:master Jul 23, 2021
@leosvelperez leosvelperez deleted the run-commands-readywhen-single-command branch July 23, 2021 17:30
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant