Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storybook): when migrating to 12.1 do not throw if project has no targets #6490

Merged
merged 1 commit into from Jul 23, 2021
Merged

fix(storybook): when migrating to 12.1 do not throw if project has no targets #6490

merged 1 commit into from Jul 23, 2021

Conversation

mandarini
Copy link
Member

ISSUES CLOSED: #6128

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jul 23, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/29kRPvBLrB6ZcmVPUNWSHQWXF3xX
✅ Preview: Canceled

@mandarini mandarini requested a review from juristr July 23, 2021 11:25
@mandarini mandarini self-assigned this Jul 23, 2021
@mandarini mandarini added the scope: storybook Issues related to Storybook support in Nx label Jul 23, 2021
juristr
juristr approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nx-cloud
Copy link

nx-cloud bot commented Jul 23, 2021

Nx Cloud Report

CI ran the following commands for commit 23d267d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --base=1655f4b6dd87b7ee33065f8f2a56c48600589c9f --parallel --max-parallel=3
#000000 nx affected --target=e2e --base=1655f4b6dd87b7ee33065f8f2a56c48600589c9f
#000000 nx affected --target=lint --base=1655f4b6dd87b7ee33065f8f2a56c48600589c9f --parallel --max-parallel=4
#000000 nx affected --target=test --base=1655f4b6dd87b7ee33065f8f2a56c48600589c9f --parallel --max-parallel=2
#000000 nx build typedoc-theme

Sent with 💌 from NxCloud.

@mandarini mandarini merged commit a4020b0 into nrwl:master Jul 23, 2021
@mandarini mandarini deleted the feat/storybook-allow-no-targets branch March 18, 2022 14:49
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juristr juristr juristr approved these changes

Assignees

@mandarini mandarini

Labels
scope: storybook Issues related to Storybook support in Nx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent failure migrating from 12.0.8 to 12.1.0 or later
2 participants
@mandarini @juristr