Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): make workspace tsc executor to handle dependencies #6475

Merged
merged 1 commit into from Jul 23, 2021

Conversation

leosvelperez
Copy link
Member

Current Behavior

When a workspace buildable library depends on another buildable library, the build fails.

Expected Behavior

Workspace buildable libraries should build successfully when they depend on another workspace buildable library.

Related Issue(s)

Fixes #6468

@leosvelperez leosvelperez self-assigned this Jul 22, 2021
@vercel
Copy link

vercel bot commented Jul 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/2WJWpDzQ5PdKsvKDbqksohjrUR6i
✅ Preview: Canceled

@bhuber2010
Copy link
Contributor

think I just found out this doesn't fix it if the target isn't named "build". I had it named "build-base" then found this issue/PR and was like ok it should work if I'm on the right version, but still didn't. Renamed the target to just "build' and boom it worked.

@elmarbeckmann
Copy link

elmarbeckmann commented Dec 7, 2021

think I just found out this doesn't fix it if the target isn't named "build". I had it named "build-base" then found this issue/PR and was like ok it should work if I'm on the right version, but still didn't. Renamed the target to just "build' and boom it worked.

@leosvelperez have you seen this? I have the same issues still (using nx 12.10.0) and in my case renaming my target 'build-stage' is not directly possible as this is a 'sub' step in the build target.

@FrozenPandaz maybe you can help with this too?

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails for lib when importing a publishable workspace library into another publishable workspace library
3 participants