Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devkit): add font file extensions to binaryExts in generate-files.ts #6439

Merged
merged 1 commit into from Jul 29, 2021

Conversation

erikagiroux
Copy link
Contributor

Add font file extensions to the list of extensions that should not be rendered with ejs

Current Behavior

When using generateFiles, font files (.woff2, .ttf, etc.) are treated as template files and are rendered by ejs. However, they are binary files and they sometimes contain characters that interfere with ejs's templating engine, resulting in errors like this:

Error: Could not find matching close tag for "<%".

Custom generators can conceivably contain font files in order to generate a web app so it's safer to make sure ejs does not try to render them.

Expected Behavior

Font files should be in the binaryExts list in order to be excluded from ejs rendering, just like image files.

Related Issue(s)

Fixes #5213

@vercel
Copy link

vercel bot commented Jul 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/CsRu4gkpVM7xhheu8zG5WiTib6F5
✅ Preview: Canceled

[Deployment for d47f448 canceled]

Add font file extensions to the list of extensions that should not be rendered with ejs

ISSUES CLOSED: nrwl#5213
@FrozenPandaz FrozenPandaz assigned FrozenPandaz and unassigned jaysoo Jul 29, 2021
@FrozenPandaz FrozenPandaz merged commit 9f1e530 into nrwl:master Jul 29, 2021
FrozenPandaz pushed a commit that referenced this pull request Jul 29, 2021
….ts (#6439)

Add font file extensions to the list of extensions that should not be rendered with ejs

ISSUES CLOSED: #5213

Co-authored-by: egiroux <erika.giroux@ubisoft.com>
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
….ts (nrwl#6439)

Add font file extensions to the list of extensions that should not be rendered with ejs

ISSUES CLOSED: nrwl#5213

Co-authored-by: egiroux <erika.giroux@ubisoft.com>
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

font file extensions should be added to binaryExts in generateFiles
3 participants