New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devkit): make nx.json optional #6398
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/F9AvDqMi7xTD8pack4jj9qis32t7 |
ignoreNxJson
optionignoreNxJson
option
04e3d39
to
b4196c5
Compare
Nx Cloud ReportCI is running for commit 4110ae5. 📂 Click to track the progress, see the status, the terminal output, and the build insights. Sent with 💌 from NxCloud. |
b4196c5
to
e2fdcae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for contributing!
Please change the implementation to always expect nx.json
to be optional. I think it should make the logic much easier.
Allow project configuration functions to work without nx.json configuration file, this is particulary handy for regular Angular CLI projects.
e2fdcae
to
7f9151b
Compare
ignoreNxJson
optionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job! This LGTM!
Thank you so much for contributing!
* feat(devkit): make nx.json optional (#5678) Allow project configuration functions to work without nx.json configuration file, this is particulary handy for regular Angular CLI projects. * docs(devkit): make `NxJsonConfiguration` partial Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
* feat(devkit): make nx.json optional (nrwl#5678) Allow project configuration functions to work without nx.json configuration file, this is particulary handy for regular Angular CLI projects. * docs(devkit): make `NxJsonConfiguration` partial Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Devkit project configuration functions require
nx.json
file to be present on the workspace by reading it from the Tree. This breaks the compatibility with regular Angular CLI projects.Expected Behavior
Optionally read nx.json file from the Tree, this is particularly useful for using the devkit to create schematics and builders for regular Angular CLI projects.
Related Issue(s)
Fixes #5678