Consistent failure migrating from 12.0.8 to 12.1.0 or later #6128
Assignees
Labels
Comments
FrozenPandaz
added
the
scope: storybook
|
@benjamincharity can you please rerun the command with verbose, I suspect it is because of this migration: https://github.com/nrwl/nx/blob/master/packages/storybook/src/migrations/update-12-1-0/fix-storybook-tsconfig.ts#L51 |
|
Thanks for the quick response! It looks like you're on the right track: |
|
It seems to be failing at a specific library. It is a newer addition that I've inherited but to my eyes the files all seem pretty similar. I did notice that some storybook config files didn't match other libraries, but after aligning them I received the same error: ErrorI unfortunately cannot share the entire library, but I'll add tsconfig files below in case anything jumps out. tsconfig{
"extends": "../../tsconfig.base.json",
"files": [],
"include": [],
"references": [
{
"path": "./tsconfig.lib.json"
},
{
"path": "./tsconfig.lib.prod.json"
},
{
"path": "./tsconfig.spec.json"
},
{
"path": "./.storybook/tsconfig.json"
}
]
}tsconfig.lib |
|
Note: I was able to successfully migrate to 12.0.0 so all the errors seen above are when trying to migrate from 12.0.0 to a later version. |
|
Hi @benjamincharity ! Can you try the migrations using the latest version of Nx? Just in case it somehow gets resolved. And after you try it, can you please post your logs here again? Thank you very much in advance, and I hope your issue gets resolved quickly! |
|
Just did some debugging on this myself. In my case I had a project listed in the just adding |
|
Alright @mandarini I finally got some time to try this.. I updated to Migrating from Once on I was able to migrate from And here is my updated report at this point: |
|
I attempted upgrading from 12.0.8 to 12.5.5 then yarn Reviewed all packages under node_modules/@nrwl and they seem updated to 12.5.5 Continue with
Apart from the above error, I'm wondering the following: |
|
I also tried upgrading from |
The migrator will run all migrations from the version you are to the target version, one by one. So it's expected. |
|
Hi both. Thanks for reporting on this issue. I notice that your error is found into the Looking into this file (in the Let's see what the From that, I can assume that your I can push a fix to account for that niche use case, though! :) |
|
Hi @mandarini - thanks for looking into this. I can see a target object for each of my apps and libs. Does the main project also require a target? |
|
HI @ivanji ! Which would the "main" project be? Can I see your |
|
Sure! |
|
I see has no |
|
You're right - when I removed this library from the workspace, updating to the latest version worked! But how am I supposed to have stylesheets only libraries in my project which don't need targets? Probably, adding a fix for this like you suggested for this type of situations would help. Or could you suggest an alternative? Thanks! |
mandarini
added a commit
to mandarini/nx
that referenced
this issue
Jul 23, 2021
… targets ISSUES CLOSED: nrwl#6128
|
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current Behavior
I am seeing a consistent failure when migrating from
12.0.8to12.1.0or later.(full error below)
latest,12.4.0,12.3.6,12.3.0and12.1.0.node_modulesandpackage-lock.jsonarchitectkey inangular.jsontsconfig.base.jsonhas apathskey.package.jsonhas adependencieskey.I have hit NX upgrade snags before but have been able to figure out a way around them but this time I'm a bit out of my depth.
Expected Behavior
Obviously the expected behavior is a successful upgrade 🙃
Steps to Reproduce
As I cannot reproduce this outside of our repo, I hesitate to call this a bug. But I am hoping someone can help point me in a better direction.
Failure Logs
Error output
Environment
NX Report
The text was updated successfully, but these errors were encountered: