New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@nrwl/devkit should expose readWorkspace #5678
Labels
Comments
edbzn
added a commit
to edbzn/nx
that referenced
this issue
Jul 16, 2021
Allow project configuration functions to work without nx.json by adding a new parameter `ignoreNxJson` to skip reading this file, this is particulary handy for regular Angular CLI projects.
edbzn
added a commit
to edbzn/nx
that referenced
this issue
Jul 16, 2021
Allow project configuration functions to work without nx.json by adding a new parameter `ignoreNxJson` to skip reading this file, this is particulary handy for regular Angular CLI projects.
edbzn
added a commit
to edbzn/nx
that referenced
this issue
Jul 16, 2021
Allow project configuration functions to work without nx.json by adding a new parameter `ignoreNxJson` to skip reading this file, this is particulary handy for regular Angular CLI projects.
edbzn
added a commit
to edbzn/nx
that referenced
this issue
Jul 16, 2021
Allow project configuration functions to work without nx.json by adding a new parameter `ignoreNxJson` to skip reading this file, this is particulary handy for regular Angular CLI projects.
edbzn
added a commit
to edbzn/nx
that referenced
this issue
Jul 26, 2021
Allow project configuration functions to work without nx.json configuration file, this is particulary handy for regular Angular CLI projects.
FrozenPandaz
added a commit
that referenced
this issue
Jul 29, 2021
* feat(devkit): make nx.json optional (#5678) Allow project configuration functions to work without nx.json configuration file, this is particulary handy for regular Angular CLI projects. * docs(devkit): make `NxJsonConfiguration` partial Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
FrozenPandaz
added a commit
that referenced
this issue
Jul 29, 2021
* feat(devkit): make nx.json optional (#5678) Allow project configuration functions to work without nx.json configuration file, this is particulary handy for regular Angular CLI projects. * docs(devkit): make `NxJsonConfiguration` partial Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
ManojBahuguna
pushed a commit
to ManojBahuguna/nx
that referenced
this issue
Sep 16, 2021
* feat(devkit): make nx.json optional (nrwl#5678) Allow project configuration functions to work without nx.json configuration file, this is particulary handy for regular Angular CLI projects. * docs(devkit): make `NxJsonConfiguration` partial Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Some generators could be "Angular CLI schematics" compatible but they are not, because they directly or indirectly call functions like
readProjectConfiguration
that makenx.json
presence mandatory:nx/packages/devkit/src/generators/project-configuration.ts
Lines 155 to 173 in 4a53453
It would be nice to make the API more explicit on when
nx.json
is read & required.Motivation
This improvement could:
@nrwl/devkit
Suggested Implementation
In order to avoid introducing any breaking change, we could add an optional boolean
ignoreNxJson
parameter to these functions. We could provide different signatures with different return types depending on the value of this option.Alternate Implementations
Exposing
readWorkspace
could be a good start.nx/packages/devkit/src/generators/project-configuration.ts
Line 279 in 4a53453
We, @jscutlery, would be happy to discuss this and provide a PR.
Cc. @edbzn
The text was updated successfully, but these errors were encountered: