Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): updated dotenv and switched to import 'dotenv/config' #5615

Merged
merged 1 commit into from Jul 29, 2021
Merged

feat(core): updated dotenv and switched to import 'dotenv/config' #5615

merged 1 commit into from Jul 29, 2021

Conversation

Phillip9587
Copy link
Contributor

@Phillip9587 Phillip9587 commented May 10, 2021 •
edited

Current Behavior

  • dotenv 8.2.0

Expected Behavior

  • updated dotenv to 10.0.0
  • added the migration to @nrwl/workspace
  • switched from require('dotenv').config() to import 'dotenv/config'

@vercel
Copy link

vercel bot commented May 10, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/2NMbpHrJk61JVHos9xVaJo8Zz2UJ
✅ Preview: https://nx-dev-git-fork-phillip9587-update-dotenv-nrwl.vercel.app

@nx-cloud
Copy link

nx-cloud bot commented May 10, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 7aa706a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --base=9f1e530cef42deb043249b72d2ba1cb874d6c4c3 --parallel --max-parallel=3
#000000 nx affected --target=e2e --base=9f1e530cef42deb043249b72d2ba1cb874d6c4c3
#000000 nx affected --target=lint --base=9f1e530cef42deb043249b72d2ba1cb874d6c4c3 --parallel --max-parallel=4
#000000 nx affected --target=test --base=9f1e530cef42deb043249b72d2ba1cb874d6c4c3 --parallel --max-parallel=2
#000000 nx build typedoc-theme

Sent with 💌 from NxCloud.

@vsavkin
Copy link
Member

vsavkin commented May 18, 2021

Thank you! Could you resolve the conflict?

@Phillip9587
Copy link
Contributor Author

@vsavkin The merge conflicts are resolved but there is the new version 14.17.0 of @types/node. Should i update the migration to install the latest types?

@puku0x
Copy link
Contributor

puku0x commented May 23, 2021

There is a new PR for dotenv v10👀 #5754

@Phillip9587
Copy link
Contributor Author

Phillip9587 commented May 24, 2021 •
edited

Updated this PR to dotenv 10.0.0

@gperdomor
Copy link
Contributor

Sorry I don't see this PR before, I will close the other :D

@gperdomor gperdomor mentioned this pull request May 25, 2021
Closed
FrozenPandaz
FrozenPandaz approved these changes Jul 29, 2021
View reviewed changes
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FrozenPandaz FrozenPandaz merged commit 1b5498f into nrwl:master Jul 29, 2021
FrozenPandaz pushed a commit that referenced this pull request Jul 29, 2021
@Phillip9587 @FrozenPandaz
feat(core): updated dotenv and switched to import 'dotenv/config' (#5615
b7fb7f2 
)
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
@Phillip9587 @ManojBahuguna
feat(core): updated dotenv and switched to import 'dotenv/config' (nr…
9898b44 
…wl#5615)
@Phillip9587 Phillip9587 deleted the update-dotenv branch September 21, 2022 11:56
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

Assignees

@FrozenPandaz FrozenPandaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Phillip9587 @vsavkin @puku0x @gperdomor @FrozenPandaz