New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
font file extensions should be added to binaryExts in generateFiles #5213
Labels
Comments
erikagiroux
added a commit
to erikagiroux/nx
that referenced
this issue
Jul 20, 2021
Add font file extensions to the list of extensions that should not be rendered with ejs ISSUES CLOSED: nrwl#5213
erikagiroux
added a commit
to erikagiroux/nx
that referenced
this issue
Jul 20, 2021
Add font file extensions to the list of extensions that should not be rendered with ejs ISSUES CLOSED: nrwl#5213
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current Behavior
Binary files like font files can sometimes contain characters like
<%
and this can result in an error when running generateFiles because ejs tries to find a closing tag that does not exist. In my case, it happens with a .woff2 file but it could happen with other file types as well.The error looks like this:
Expected Behavior
Binary files should not be rendered with ejs. I know image files have already been excluded. The same could be done with font files. The most common extensions for web fonts could be added to the list of binaryExts:
It would be even better if we could identify binary formats automatically but since image extensions were added manually, it would make sense to include fonts too in order to cover the most common web assets.
Steps to Reproduce
<%
somewhere it its contentEnvironment
This is a blank workspace created by
npx create-nx-plugin
. It contains only a generator.The text was updated successfully, but these errors were encountered: