Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): run-commands should fail when a command in serial fails #4477

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Running a target that uses run-commands to run commands serially will not error if a command errors.

For example, the Nx build succeeds even when one package fails to build which as a result causes it to be cached as a success.

Expected Behavior

Running a target that uses run-commands to run commands serially will error if a command errors.

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Jan 9, 2021

Nx Cloud Report

CI ran the following commands for commit d236502. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx run-many --target=build --all --parallel 1/11/2021, 3:32:24 PM
#000000 nx run-many --target=e2e --projects=e2e-angular 1/11/2021, 3:35:18 PM
#000000 nx run-many --target=e2e --projects=e2e-cypress,e2e-jest 1/11/2021, 3:34:30 PM
#000000 nx run-many --target=e2e --projects=e2e-next 1/11/2021, 3:33:01 PM
#000000 nx run-many --target=e2e --projects=e2e-node 1/11/2021, 3:34:14 PM
#000000 nx run-many --target=e2e --projects=e2e-nx-plugin 1/11/2021, 3:34:31 PM
#000000 nx run-many --target=e2e --projects=e2e-react 1/11/2021, 3:30:45 PM
#000000 nx run-many --target=e2e --projects=e2e-web,e2e-linter,e2e-storybook 1/11/2021, 3:33:52 PM
#000000 nx run-many --target=e2e --projects=e2e-workspace 1/11/2021, 3:28:57 PM

Sent with 💌 from NxCloud.

@FrozenPandaz FrozenPandaz merged commit 82f801b into nrwl:master Jan 11, 2021
@FrozenPandaz FrozenPandaz deleted the fix-run-commands branch January 11, 2021 17:19
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant