-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter): Respect the "quiet" option #4330
Conversation
Respect the "quiet" configuration option by filtering out warnings, leavning only errors. This takes the same approach as the eslint CLI. Closes nrwl#3946
Nx Cloud ReportCI ran the following commands for commit 6249377. Click to see the status, the terminal output, and the build insights.
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra console log left in, otherwise I think this is good to go
Co-authored-by: James Henry <james@henry.sc>
should this be working with the run-many command as well?
...does not pass the --quiet argument to the child runners. the following does work with the quiet option
|
Any idea when this till be pushed to the project? I ran a fresh install and still have this error. |
also interested |
I just had a super quick look at a project which is not on the latest (it's on Nx If you are having issues in spite of this change when using the eslint executor please report them as new issues by following the issue templates |
@JamesHenry
maybe I need to update something else? |
The
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The eslint plugin doesn't properly respect the "quiet" configuration option, displaying warnings even if "quiet" is
true
.Expected Behavior
The eslint plugin should respect the "quiet" configuration option, not displaying errors if it is
true
.Related Issue(s)
Fixes #3946