Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): Respect the "quiet" option #4330

Merged
merged 2 commits into from
Jan 2, 2021
Merged

Conversation

arabull
Copy link
Contributor

@arabull arabull commented Dec 17, 2020

Current Behavior

The eslint plugin doesn't properly respect the "quiet" configuration option, displaying warnings even if "quiet" is true.

Expected Behavior

The eslint plugin should respect the "quiet" configuration option, not displaying errors if it is true.

Related Issue(s)

Fixes #3946

Respect the "quiet" configuration option by filtering out warnings, leavning only errors. This takes the same approach as the eslint CLI.

Closes nrwl#3946
@nx-cloud
Copy link

nx-cloud bot commented Dec 17, 2020

Nx Cloud Report

CI ran the following commands for commit 6249377. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx build-base linter 12/22/2020, 8:27:40 PM
#000000 nx run-many --target=build --all --parallel 12/22/2020, 8:27:37 PM
#000000 nx run-many --target=e2e --projects=e2e-linter 12/22/2020, 8:29:50 PM
#000000 nx run-many --target=lint --all --parallel 12/22/2020, 8:29:41 PM
#000000 nx run-many --target=test --all --parallel 12/22/2020, 8:28:19 PM

Sent with 💌 from NxCloud.

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra console log left in, otherwise I think this is good to go

packages/linter/src/builders/eslint/lint.impl.spec.ts Outdated Show resolved Hide resolved
@JamesHenry JamesHenry added the scope: linter Issues related to Eslint support in Nx label Dec 22, 2020
Co-authored-by: James Henry <james@henry.sc>
@ahaskell35
Copy link

ahaskell35 commented Feb 12, 2021

should this be working with the run-many command as well?
current version I am using (11.2.12) with this command:

nx run-many --target=lint -all --quiet

...does not pass the --quiet argument to the child runners.

the following does work with the quiet option

nx lint {project} --quiet

@james-wilkinson-thd
Copy link

Any idea when this till be pushed to the project? I ran a fresh install and still have this error.

@cakeinpanic
Copy link

also interested

@JamesHenry
Copy link
Collaborator

I just had a super quick look at a project which is not on the latest (it's on Nx 11.3.2) and this change is present in my installed Nx, so I would say make sure you are using a version that was released after this PR was merged (11.3.2 or later for sure) and it should be there.

If you are having issues in spite of this change when using the eslint executor please report them as new issues by following the issue templates

@cakeinpanic
Copy link

@JamesHenry
here is what I'm running

> nx lint client --quiet
> nx run client:lint --quiet 
'quiet' is not found in schema
    "@nrwl/cli": "12.0.7",
    "@nrwl/linter": "12.0.7",
    "@nrwl/nx-cloud": "11.2.0",
    "@nrwl/workspace": "12.0.7",

maybe I need to update something else?

@dandean
Copy link

dandean commented Apr 23, 2021

The --quiet flag doesn't appear to work via nx affected:lint --quiet.

nx --version
11.6.0

@JamesHenry
Copy link
Collaborator

@ahaskell35 @cakeinpanic @james-wilkinson-thd @dandean #5498

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx lint with --quiet not hiding warnings
6 participants