-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jest config do not get update when lib or app is deleted by remove schematic #4192
Comments
Good catch @suwigyarathore! I just noticed this. I will try to open a PR tonight |
@mehrad-rafigh I believe it's the same issue when you run the |
@etkachev I already guessed it. I will try to open a seperate PR for the move schematics. Alright? |
@mehrad-rafigh awesome! thank you for taking care of this 😄 |
@etkachev My pleasure! I opened another issue for the move schematic and am currently adjusting the schematic. I already wrote the test for it, so I guess I will create a PR during the evening |
Fixed with #4227 |
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Current Behavior
When lib or app is deleted by remove schematic the root level jest.config.js is not updated by removing the entry of deleted project. I have to manually delete the entry from this file.
yarn nx generate remove <lib-name>
Expected Behavior
jest.config.js need to automatically update by deleting the entry of deleted project
Steps to Reproduce
Step 1: Create new lib with below command
yarn nx g @nrwl/node:library <lib-name>
Step 2: Check root level jest.config.js for entry of newly created lib as result of Step 1
Step 3: Delete lib created in Step 1 by below command
yarn nx generate remove <lib-name>
Step 4: Check root level jest.config.js again the entry of newly created lib as result of Step 1 is still there
Environment
Note: nx is shown as not found below because as i did not installed nx globally
nx : Not Found @nrwl/angular : Not Found @nrwl/cli : 10.3.0 @nrwl/cypress : 10.3.0 @nrwl/eslint-plugin-nx : 10.3.0 @nrwl/express : Not Found @nrwl/jest : 10.3.0 @nrwl/linter : 10.3.0 @nrwl/nest : Not Found @nrwl/next : 10.3.0 @nrwl/node : 10.3.0 @nrwl/react : 10.3.0 @nrwl/schematics : Not Found @nrwl/tao : 10.3.0 @nrwl/web : 10.3.0 @nrwl/workspace : 10.3.0 typescript : 4.0.3
The text was updated successfully, but these errors were encountered: