Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematic @nrwl/workspace:move should update .eslintrc #2951

Closed
beeman opened this issue May 3, 2020 · 1 comment · Fixed by #4489
Closed

Schematic @nrwl/workspace:move should update .eslintrc #2951

beeman opened this issue May 3, 2020 · 1 comment · Fixed by #4489
Labels
community This is a good first issue for contributing outdated scope: misc Misc issues type: bug

Comments

@beeman
Copy link
Contributor

beeman commented May 3, 2020

Expected Behavior

Today I found the @nrwl/workspace:move schematic, great addition!

When using it though, the import in .eslintrc is not updated which causes an error.

Current Behavior

The .eslintrc file in the library does not get updated, other files like jest.config.js and tsconfig.json do get updated.

Failure Information (for bugs)

nx run api-data:lint

Linting "api-data"...
Failed to load config "../../.eslintrc" to extend from.
Referenced from: /Users/beeman/kikstart/kikstart-store/libs/api/data/.eslintrc

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. nx g @nrwl/nest:lib data
  2. nx g @nrwl/workspace:move --projectName data --destination api/data
  3. nx run api-data:lint

Other

The fix is to update .eslintrc:

{
+  "extends": "../../../.eslintrc",
-  "extends": "../../.eslintrc",
  "rules": {},
  "ignorePatterns": ["!**/*"]
}
@brandonroberts brandonroberts added scope: core core nx functionality type: bug labels May 6, 2020
@FrozenPandaz FrozenPandaz added the community This is a good first issue for contributing label Aug 14, 2020
@vsavkin vsavkin added scope: misc Misc issues and removed scope: core core nx functionality labels Sep 3, 2020
vsavkin pushed a commit that referenced this issue Jan 11, 2021
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community This is a good first issue for contributing outdated scope: misc Misc issues type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants