-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(core): add warning if running on an outdated global installation #15408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FrozenPandaz
merged 1 commit into
nrwl:master
from
AgentEnder:fix/warn-if-outdated-global-install
Mar 3, 2023
Merged
fix(core): add warning if running on an outdated global installation #15408
FrozenPandaz
merged 1 commit into
nrwl:master
from
AgentEnder:fix/warn-if-outdated-global-install
Mar 3, 2023
+227
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6a1e4f3
to
0b8ae09
Compare
0b8ae09
to
f7322c0
Compare
f7322c0
to
8ac2c24
Compare
bcabanes
approved these changes
Mar 3, 2023
FrozenPandaz
requested changes
Mar 3, 2023
8ac2c24
to
22a52f6
Compare
22a52f6
to
e98b338
Compare
e98b338
to
cf35973
Compare
FrozenPandaz
approved these changes
Mar 3, 2023
AgentEnder
added a commit
to AgentEnder/nx
that referenced
this pull request
Mar 4, 2023
…llation (nrwl#15408)" This reverts commit e773bdb.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
There is no warnings or documentation to help guide users who have an outdated installation.
Expected Behavior
Starting with the next version, users who have it installed globally and the local copy of Nx is at least 1 major version higher will see warnings explaining that they have an outdated global install. Due to the nature of this change, users who currently have an outdated install will not see the warnings, but this at least helps future users or folks who upgrade it.
Additionally, there is a guide added to describe the upgrade process and be searchable. This guide is not currently linked anywhere from the sidebar, perhaps it should be on the more-concepts index though.
Related Issue(s)
Fixes #15112