Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fixes library type not passed to the module federation conf #15385

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

infoxicator
Copy link
Contributor

@infoxicator infoxicator commented Mar 2, 2023

the withModuleFederation plugin doesn't allow the library type to be configured using the module-federation.config.js file because the value is hardcoded.

This change allows the library type to be passed:

module.exports = {
  name: 'test-app',
  library: { type: 'var', name: 'test-app' },
  exposes: {
    './Test': './src/index',
  },
  // remotes: [],
};

closed #15316

Current Behavior

library type is always 'module'

Expected Behavior

passing library: { type: 'var' } should override the default value

Related Issue(s)

Fixes #15316

Verified

This commit was signed with the committer’s verified signature.
…nfiguration

closed nrwl#15316
@vercel
Copy link

vercel bot commented Mar 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 2, 2023 at 4:55PM (UTC)

@mandarini mandarini merged commit c054251 into nrwl:master Mar 2, 2023
FrozenPandaz pushed a commit that referenced this pull request Mar 2, 2023

Verified

This commit was signed with the committer’s verified signature.
…nf (#15385)

(cherry picked from commit c054251)
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withModuleFederation Library type
2 participants