-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix(js): integrate buildable bundler and compiler options #15376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+353
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5b2c1e5
to
fab4643
Compare
fab4643
to
be7e565
Compare
nartc
reviewed
Mar 2, 2023
barbados-clemens
approved these changes
Mar 2, 2023
be7e565
to
b3f9fa7
Compare
mandarini
commented
Mar 2, 2023
jaysoo
approved these changes
Mar 2, 2023
nartc
approved these changes
Mar 2, 2023
b3f9fa7
to
f7d6ff9
Compare
f7d6ff9
to
fb5c7d9
Compare
341b27a
to
543df9e
Compare
nartc
approved these changes
Mar 2, 2023
543df9e
to
f04fac9
Compare
f04fac9
to
bf6a414
Compare
bf6a414
to
bcea791
Compare
bcea791
to
bac7a9e
Compare
bac7a9e
to
faa223f
Compare
AgentEnder
approved these changes
Mar 3, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 3, 2023
(cherry picked from commit b84125f)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from here: #15090
After discussions, we decided to integrate the
buildbale
,bundler
andcompiler
options of thejs:lib
generator, to make it more transparent.So, the changes are on the
@nrwl/js:lib
generator. See the NEW documentation here.Current behaviour
If we don't pass the
buildable
flag, and we don't pass abundler
either, then library will be buildable with@nrwl/js:tsc
as thebuild
executor
since it defaults to "@nrwl/js:tsc" executor.If you do pass the
buildable
flag and miss to pass thebundler
, it will default to@nrwl/js: + options.compiler
for the executor.The only way to get the
@nrwl/js:tsc
or@nrwl/js:swc
executors is to leave bundler undefinedThe only way to get a non-buildable lib is to specifically pass
--bundler=none
So we need to find a way to deprecate the
buildable
flag, but still be able to get thejs:tsc
orjs:swc
executors from the bundler. And make the behaviour more transparent.Expected behaviour
Use Case 1: Don't want to bundle but want to build
Use Case 2: Want to bundle
Use Case 3: Not buildable/bundled
Cases we want to deprecate: