fix(testing): walk all project deps to check if CT project is used in buildTarget #15252
+289
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
barbados-clemens
force-pushed
the
fix/use-assets-for-any-descendant-project-ng-ct
branch
from
8fd2e7c to
86b6bed
Compare
barbados-clemens
requested review from
meeroslav,
vsavkin,
FrozenPandaz,
Coly010 and
leosvelperez
as code owners
leosvelperez
approved these changes
Feb 27, 2023
FrozenPandaz
approved these changes
Feb 28, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
barbados-clemens
deleted the
fix/use-assets-for-any-descendant-project-ng-ct
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
being more than 1 node away from the defined 'buildTarget' would not allows assets/scripts/styles to be included in the dynamic project config that angular CT creates for cypress.
Expected Behavior
The CT plugin walks all the deps from the buildTarget project to check if the CT project is being used instead of direct dependencies of buildTarget.
TODO
Related Issue(s)
Fixes #14881