Skip to content

fix(angular): handle projects without name in angular cli adapter #15089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leosvelperez
Copy link
Member

Current Behavior

When a project.json file is missing its name property, the Angular CLI adapter fails with Cannot read properties of undefined (reading 'data').

Expected Behavior

The Angular CLI adapter should gracefully handle project.json files missing their name property. The config should be updated with the name.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Feb 17, 2023
@vercel
Copy link

vercel bot commented Feb 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 2:44PM (UTC)

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants