fix(detox): Update rn and expo buildTargets #15073
Merged
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the React Native and Expo test targets were not being created with the correct buildTarget for the platforms iOS and Android. This caused issues when running e2e tests for Android. To fix this issue, I updated the React Native and Expo test targets to ensure that the correct buildTarget is created for each platform. This ensures that the creation of project.json is accurate and reliable.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
xiongemi
approved these changes
Feb 16, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the React Native and Expo test targets were not being created with the correct buildTarget for the platforms iOS and Android. This caused issues when running e2e tests for Android.
To fix this issue, I updated the React Native and Expo test targets to ensure that the correct buildTarget is created for each platform. This ensures that the creation of project.json is accurate and reliable.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #