Skip to content

fix(devkit): only install deps with higher version #14630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

When deps has a higher version, devDeps will also be installed causing an issue where devDeps might install lower versions than was is already installed.

Expected Behavior

only newer (higher version) deps are installed

Related Issue(s)

Fixes #13687
Fixes: #14196

@vercel
Copy link

vercel bot commented Jan 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 25, 2023 at 9:44PM (UTC)

@barbados-clemens barbados-clemens enabled auto-merge (squash) January 25, 2023 21:59
@barbados-clemens barbados-clemens merged commit f337641 into nrwl:master Jan 25, 2023
FrozenPandaz pushed a commit that referenced this pull request Jan 27, 2023
@barbados-clemens barbados-clemens deleted the fix/only-update-deps-if-newer branch January 27, 2023 16:55
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants