Skip to content

fix(vite): delete webpack config when converting #14582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Jan 24, 2023

If webpack config file exists, delete it after converting to vite.

@vercel
Copy link

vercel bot commented Jan 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Jan 24, 2023 at 4:07PM (UTC)

@mandarini mandarini force-pushed the fix/vite-delete-webpack-config branch from 7957a08 to 2f6b7e4 Compare January 24, 2023 15:38
@nx-cloud
Copy link

nx-cloud bot commented Jan 24, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b4b7b10. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


⌛ The following targets are in progress

🟥 Failed Commands
nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
nx affected --target=test --base=fea80afd5c37aa69ccc36db7cdb1da9fd433d9ff --head=2f6b7e4c973c764ca23972f41609f2dea4b949a7 --parallel=1
✅ Successfully ran 18 targets

Sent with 💌 from NxCloud.

@mandarini mandarini force-pushed the fix/vite-delete-webpack-config branch from 2f6b7e4 to db2d97b Compare January 24, 2023 16:02
@mandarini mandarini requested a review from jaysoo January 24, 2023 16:03
@mandarini mandarini self-assigned this Jan 24, 2023
@mandarini mandarini enabled auto-merge (squash) January 24, 2023 16:03
@mandarini mandarini force-pushed the fix/vite-delete-webpack-config branch from db2d97b to b4b7b10 Compare January 24, 2023 16:07
@mandarini mandarini merged commit b01aa84 into nrwl:master Jan 24, 2023
vsavkin pushed a commit that referenced this pull request Jan 24, 2023

Verified

This commit was signed with the committer’s verified signature. The key has expired.
vsavkin Victor Savkin
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants