Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-many crash on packages lacking specified target in 15.4.3 #14511

Closed
miluoshi opened this issue Jan 20, 2023 · 2 comments
Closed

run-many crash on packages lacking specified target in 15.4.3 #14511

miluoshi opened this issue Jan 20, 2023 · 2 comments

Comments

@miluoshi
Copy link
Contributor

miluoshi commented Jan 20, 2023

Current Behavior

This is the same bug that was created in 15.1.0, then was fixed in 15.2.0 and then again was broken by this PR in 15.4.3.

If run-many is run with list of packages and some of those packages are lacking the specified target the command ends with fail state.

Expected Behavior

The run-many runs on successfully and skips projects without the target as in nx prior 15.4.3.

Steps to Reproduce

  1. run nx run-many --projects=<existing_projects_list> --target=<non-existent-target>
  2. command fails with following error:
    Error: No projects found for project patterns
      at projectsToRun (/path-to-project/node_modules/nx/src/command-line/run-many.js:59:15) 
    

Nx Report

>  NX   Report complete - copy this into the issue template

   Node : 18.12.1
   OS   : darwin x64
   yarn : 1.22.18
   
   nx : 15.4.3
   @nrwl/angular : 15.4.3
   @nrwl/cypress : 15.4.3
   @nrwl/detox : Not Found
   @nrwl/devkit : 15.4.3
   @nrwl/esbuild : Not Found
   @nrwl/eslint-plugin-nx : 15.4.3
   @nrwl/expo : Not Found
   @nrwl/express : Not Found
   @nrwl/jest : 15.4.3
   @nrwl/js : 15.4.3
   @nrwl/linter : 15.4.3
   @nrwl/nest : Not Found
   @nrwl/next : Not Found
   @nrwl/node : Not Found
   @nrwl/nx-cloud : 15.0.2
   @nrwl/nx-plugin : Not Found
   @nrwl/react : 15.4.3
   @nrwl/react-native : Not Found
   @nrwl/rollup : 15.4.3
   @nrwl/schematics : Not Found
   @nrwl/storybook : 15.4.3
   @nrwl/web : 15.4.3
   @nrwl/webpack : 15.4.3
   @nrwl/workspace : 15.4.3
   @nrwl/vite : 15.4.3
   typescript : 4.8.4
   ---------------------------------------
   Local workspace plugins:
   ---------------------------------------
   Community plugins:
         @ngrx/component-store: 15.0.0
         @ngrx/effects: 15.0.0
         @ngrx/entity: 15.0.0
         @ngrx/store: 15.0.0
         @ngrx/schematics: 15.0.0
         @storybook/angular: 6.5.15
         @testing-library/angular: 13.1.0
@AgentEnder
Copy link
Member

This should be fixed in latest. The PR fixing it was #14238. Any version over 15.4.5 should contain the fix.

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants