fix(js): node executor address already in use

[sahilpurav]

Due to this #13813 PR, frameworks like express and nest are throwing the EADDRINUSE error after file changes.
The issue is caused by using array as key in new Map(key, value) function. I corrected it by wrapping JSON.strigify function around Map key.

BREAKING CHANGE:
NA

ISSUES CLOSED: #14017

Current Behavior

Wherever we have @nrwl/js:node executor (express, nest etc.) after each file changes, we are getting EADDRINUSE error.

Expected Behavior

Every file changes should be seamlessly watched by @nrwl/js:node executor and changes should be instantly available while serving the application locally.

Related Issue(s)

#14024
#14023

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
nx-dev	⬜️ Ignored (Inspect)		Dec 26, 2022 at 7:22PM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9385ce7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 11 targets

• nx affected --target=e2e --base=d3ef0eaf7214a09709882240b736a5a50c970864 --head=9385ce7adfad685c5766b91e0903bccc85c67e7a --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=test --base=d3ef0eaf7214a09709882240b736a5a50c970864 --head=9385ce7adfad685c5766b91e0903bccc85c67e7a --parallel=1
• nx depcheck --no-dte
• nx affected --target=build --base=d3ef0eaf7214a09709882240b736a5a50c970864 --head=9385ce7adfad685c5766b91e0903bccc85c67e7a --parallel=3
• nx lint --no-dte
• nx check-lock-files --no-dte
• nx affected --target=lint --base=d3ef0eaf7214a09709882240b736a5a50c970864 --head=9385ce7adfad685c5766b91e0903bccc85c67e7a --parallel=3
• nx check-commit --no-dte
• nx-cloud record -- nx format:check --base=d3ef0eaf7214a09709882240b736a5a50c970864 --head=9385ce7adfad685c5766b91e0903bccc85c67e7a
• nx check-imports --no-dte
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[LonguCodes]

Would be great if someone can merge this

[DavidRojoM]

Good catch!

[mrfy]

Please merge!

[sahilpurav]

Please merge!

💯. Waiting for someone to approve. I'm equally eager to have this fix as it is basic requirement to watch the express and nest files. In the meanwhile, build your application on nx@15.3.3

@AgentEnder Help please :)

[firxworx]

@AgentEnder thanks for your help! Seeing as you're at Nx + sort of related, something I was thinking about: since adopting nx for most of my projects these sorts of issues do seem to crop up semi-frequently and overall they can undermine productivity which is against the whole point of Nx as I understand it.

For example

• Old projects can behave differently than new projects (even with similar stack + apps + etc) in quirky ways
• Running nx migrate seems OK at first and everything passes but then some new "fun" troubleshooting cases pop up later somewhere in the dev workflow.

Thought/Suggestion

I have no idea what the testing approach is like on your side, so please forgive me if there's anything like this or even better in place and this is just a hard thing to test with a lot of moving parts... It has crossed my mind if some sort of "e2e but for the dev + deploy experience" tests were in place they could help catch many of these sorts of issues pre-release.

For example imagine tests involving both barebones projects and more elaborate multi-app multi-lib setups that really flex the full extent of nx, with scenario coverage of totally new projects being created as well as legacy projects getting updated, etc.

It seems to me that this would be an example of something that could be caught because it would impact a scenario like:

"dev with node project makes changes to app running in dev and the app reloads with their changes"

Failing tests for this issue might be, e.g. that there is error output in the console where none is expected (in this case about an address in use), that the dev's change (e.g. "{ hello: 'world' }" -> "{ bonjour: 'monde' }") wasn't reflected in API response as expected, etc.

Anyway, random two cents. Thanks!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.