why library's package.json inside dist folder not showing peer dependency of react and react-dom?

[nsit8919]

Current Behavior

showing dependency of react and react-dom in package.json file . react build

Expected Behavior

react and react-dom should come in peer dependency as it is library .

Github Repo

No response

Steps to Reproduce

Hi Follow all steps mentioned here

https://nx.dev/getting-started/react-standalone-tutorial
But when I am creating build of my library .In the package.json file inside dist folder .It is showing react and react-dom as dependency . It should show as a peer dependency . is it possible ?

Nx Report

NX

Failure Logs

No response

Additional Information

No response

[atanaskanchev]

I think this PR is fixing that

[meeroslav]

@nsit8919, you didn't mention which build you have selected for that library.

Generally, packages are considered as dependencies if they are directly used (via import in the code). If you want to have it otherwise, you can create a package.json in the root of the project and specify those dependencies as peerDependencies e.g.

{
  "name": "my-package",
  "peerDependencies": {
    "react": "^18.0.0",
    "react-dom":  "^18.0.0"
  }
}

The resulting generated package.json would be this package.json expanded with missing dependencies and information. This is a common approach when creating publishable packages where the version you expect is more fluid than the one set in your root package.json or you expect some of the packages to be peer dependencies (as it is in your case)

[meeroslav]

If you still feel there is a bug, please provide a minimal reproduction so we can look into it.

[github-actions]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.