Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): using normalizePath for tailwindcss config generation #13936

Merged
merged 1 commit into from Dec 20, 2022

Conversation

IKatsuba
Copy link
Contributor

Current Behavior

Windows users get an error when running nx serve or nx build for projects with TailwindCSS, because createGlobPatternsForDependencies uses the path.relative method without normalizing the paths first.

Expected Behavior

Windows users should be able to run nx serve or nx build for projects with TailwindCSS.

Related Issue(s)

Fixes #13713

@vercel
Copy link

vercel bot commented Dec 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 7:06PM (UTC)

@IKatsuba IKatsuba changed the title fix(core): using normalizePath for tailwindcss config generation, closes #13713 fix(core): using normalizePath for tailwindcss config generation Dec 20, 2022
@AgentEnder AgentEnder changed the title fix(core): using normalizePath for tailwindcss config generation fix(misc): using normalizePath for tailwindcss config generation Dec 20, 2022
@AgentEnder AgentEnder merged commit 87a6a2d into nrwl:master Dec 20, 2022
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Dec 21, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants