fix(core): fix lock file pruning optional dependencies

[skrtheboss]

Current Behavior

Optional dependencies are omitted from the pruned .lock file.

Expected Behavior

Optional dependencies should be included in the .lock file

Related Issue(s)

Fixes #

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	Dec 15, 2022 at 8:35AM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a897734. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 11 targets

• nx affected --target=e2e --base=4f9b9d4344e127c89f7a8dd1dfadbdd8c2d89884 --head=a89773402a9caa391e61fd7c84212630d7f87098 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=test --base=4f9b9d4344e127c89f7a8dd1dfadbdd8c2d89884 --head=a89773402a9caa391e61fd7c84212630d7f87098 --parallel=1
• nx affected --target=build --base=4f9b9d4344e127c89f7a8dd1dfadbdd8c2d89884 --head=a89773402a9caa391e61fd7c84212630d7f87098 --parallel=3
• nx depcheck --no-dte
• nx affected --target=lint --base=4f9b9d4344e127c89f7a8dd1dfadbdd8c2d89884 --head=a89773402a9caa391e61fd7c84212630d7f87098 --parallel=3
• nx lint --no-dte
• nx check-lock-files --no-dte
• nx check-commit --no-dte
• nx-cloud record -- nx format:check --base=4f9b9d4344e127c89f7a8dd1dfadbdd8c2d89884 --head=a89773402a9caa391e61fd7c84212630d7f87098
• nx check-imports --no-dte
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[skrtheboss]

@meeroslav as far as I understood, you have implemented this functionality, so may I ask you to have a look at this?
Thank you.

[meeroslav]

Thank you for the PR. Please add test for npm V1 or V2 to ensure all three variants of npm lock file are working (v2 is backward compatible and contains both V1 and V3 formats).

The rest looks good to me!

[skrtheboss]

Hi @meeroslav, i have added the missing lock file tests:

• npm v1 and v3
• yarn berry

Let me know if i should add/change something else

[meeroslav]

Amazing work, @skrtheboss, thank you!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.