New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): ignore angular.json projects if @nrwl/angular is not insta… #13827
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
97b622c
to
bda2a75
Compare
@@ -431,6 +432,15 @@ function assertValidWorkspaceConfiguration( | |||
} | |||
} | |||
|
|||
function isNrwlAngularInstalled() { | |||
try { | |||
require.resolve('@nrwl/angular'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some debate on whether require.resolve
vs reading package.json and checking deps is better for this check.
This could potentially have a false positive if there was @nrwl/angular found in one of the dependency chains of another installed library, but that should be relatively rare. In any case, the behavior exhibited would be the currently existing behavior, so its a low impact.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
…lled
Current Behavior
Most workspaces use Nx and Angular together. However, workspaces which use Nx and Angular CLI entirely independently have a conflict in some package names.
Expected Behavior
Projects that use Nx and Angular entirely independently do not have
@nrwl/angular
installed and should not read projects fromangular.json
Related Issue(s)
Fixes #