Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): additional null check when hashing lockfile #13803

Merged
merged 1 commit into from Dec 14, 2022
Merged

fix(core): additional null check when hashing lockfile #13803

merged 1 commit into from Dec 14, 2022

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Dec 13, 2022 •
edited

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #13776
Fixes #13777

@vercel
Copy link

vercel bot commented Dec 13, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 10:29PM (UTC)

@AgentEnder AgentEnder mentioned this pull request Dec 13, 2022
Closed
@nx-cloud
Copy link

nx-cloud bot commented Dec 13, 2022 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 639789f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 11 targets

Sent with 💌 from NxCloud.

FrozenPandaz
FrozenPandaz previously requested changes Dec 13, 2022
View reviewed changes
packages/nx/src/lock-file/utils/hashing.ts Outdated Show resolved Hide resolved
meeroslav
meeroslav approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@meeroslav meeroslav mentioned this pull request Dec 14, 2022
Closed
@AgentEnder AgentEnder merged commit efa6ef0 into nrwl:master Dec 14, 2022
@AgentEnder AgentEnder deleted the fix/13776 branch December 14, 2022 14:22
@AgentEnder AgentEnder mentioned this pull request Dec 14, 2022
Closed
@crusoexia
Copy link

When would this get release?

@meeroslav meeroslav mentioned this pull request Dec 16, 2022
Closed
FrozenPandaz pushed a commit that referenced this pull request Dec 19, 2022
@AgentEnder @FrozenPandaz
fix(core): additional null check when hashing lockfile (#13803)
8f6961c 
Fixes #13776
Fixes #13777

(cherry picked from commit efa6ef0)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meeroslav meeroslav meeroslav approved these changes

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@AgentEnder @crusoexia @meeroslav @FrozenPandaz