Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expo): update expo peer dependency to 47 #13780

Merged
merged 1 commit into from Dec 13, 2022
Merged

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from jaysoo December 13, 2022 01:30
@vercel
Copy link

vercel bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 13, 2022 at 1:30AM (UTC)

@yonitou
Copy link

yonitou commented Dec 19, 2022

Hey !
I just updated my NX packages to 15.3.3 and looks like the expo peerDependency version is still the old one (46.0.16)
Here's what I have in my package-lock.json =>

"node_modules/@nrwl/expo": {
			"version": "15.3.3",
			"resolved": "https://registry.npmjs.org/@nrwl/expo/-/expo-15.3.3.tgz",
			"integrity": "sha512-7OjG+0ZaB1k4QWDovJwVoz0R6FiIgVvxkzi6nHWfT0GYw2V7LKVEpRHbBsfq8abuhzVH1VJSU2beyYzyfQ99Lg==",
			"dev": true,
			"dependencies": {
				"@nrwl/detox": "15.3.3",
				"@nrwl/devkit": "15.3.3",
				"@nrwl/jest": "15.3.3",
				"@nrwl/linter": "15.3.3",
				"@nrwl/react": "15.3.3",
				"@nrwl/webpack": "15.3.3",
				"@nrwl/workspace": "15.3.3",
				"@svgr/webpack": "^6.1.2",
				"chalk": "^4.1.0",
				"enhanced-resolve": "^5.8.3",
				"fs-extra": "^10.1.0",
				"metro-resolver": "^0.73.3",
				"node-fetch": "^2.6.7",
				"tar-fs": "^2.1.1",
				"tsconfig-paths": "^3.9.0",
				"tsconfig-paths-webpack-plugin": "^3.5.2"
			},
			"peerDependencies": {
				"expo": "^46.0.16"
			}
		},

I already deleted my node_modules .. Do you have any idea ?

FrozenPandaz pushed a commit that referenced this pull request Dec 19, 2022
@xiongemi xiongemi deleted the fix/expo-peer-dependency branch January 16, 2023 19:38
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants