Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): rename lock file pruning function to createLockFile #13770

Merged
merged 1 commit into from Dec 12, 2022

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

packageJson,
!options.includeDevDependenciesInPackageJson
);
const prunedLockFile = createLockFile(packageJson);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the option here anymore because it is just based off the package.json that's sent in right?

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) December 12, 2022 16:21
@vercel
Copy link

vercel bot commented Dec 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 12, 2022 at 5:41PM (UTC)

@FrozenPandaz FrozenPandaz merged commit 76ee86f into nrwl:master Dec 12, 2022
@meeroslav meeroslav deleted the feat-refactor-create-lock-file branch March 14, 2023 22:17
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants