fix(core): handle local workspace projects in package.json for affected locator

[meeroslav]

Current Behavior

Workspace projects defined as dependencies in the package.json are not discovered by getTouchedNpmPackages since they don't exist on the externalNodes, causing affected command to fail.

Expected Behavior

Workspace projects defined as dependencies in the package.json should be discovered by getTouchedNpmPackages by looking at nodes and returned within touchedProjectLocators

Related Issue(s)

Fixes #13668

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	Dec 12, 2022 at 3:58PM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 72afffb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 11 targets

• nx affected --target=e2e --base=af157ffa2bf2d9efd2ddaf7a0dd6f3ff5108b4bf --head=72afffb7ec052d5fb14441ff26c149c17b767d39 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=test --base=af157ffa2bf2d9efd2ddaf7a0dd6f3ff5108b4bf --head=72afffb7ec052d5fb14441ff26c149c17b767d39 --parallel=1
• nx affected --target=build --base=af157ffa2bf2d9efd2ddaf7a0dd6f3ff5108b4bf --head=72afffb7ec052d5fb14441ff26c149c17b767d39 --parallel=3
• nx depcheck --no-dte
• nx affected --target=lint --base=af157ffa2bf2d9efd2ddaf7a0dd6f3ff5108b4bf --head=72afffb7ec052d5fb14441ff26c149c17b767d39 --parallel=3
• nx lint --no-dte
• nx check-lock-files --no-dte
• nx check-commit --no-dte
• nx-cloud record -- nx format:check --base=af157ffa2bf2d9efd2ddaf7a0dd6f3ff5108b4bf --head=72afffb7ec052d5fb14441ff26c149c17b767d39
• nx check-imports --no-dte
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[timfishercs]

I think potentially this code needs updating as well Error: Invalid project name is detected: "npmPackage"

/node_modules/nx/src/project-graph/affected/affected-project-graph.js:63:15

[meeroslav]

@timfishercs, can you show me your npm-packages.js? The npmPackage is only used as a parameter name. I don't see how it could end up in touchedProjects in affected-project-graph.js.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.