Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle undefined when package.json changes are not in node modules #13681

Conversation

jericopingul
Copy link
Contributor

ISSUES CLOSED: #13668

Current Behavior

nx affected fails with error

Expected Behavior

nx affected does not fail with error

Related Issue(s)

Fixes #13668

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 8, 2022 at 10:36PM (UTC)

Copy link

@giveerr giveerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solves the problem

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please show a warning in these cases so we can identify which cases weren't handle.

@meeroslav meeroslav changed the title fix(core): handle undefined when package.json changes are not in npm packages fix(core): handle undefined when package.json changes are not in node modules Dec 9, 2022
@FrozenPandaz FrozenPandaz merged commit af157ff into nrwl:master Dec 12, 2022
@jericopingul jericopingul deleted the jericopingul/handle-nx-affected-workspace-change branch December 17, 2022 13:52
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'name') when running nx affected
4 participants