Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): enable hmr by default for Vite dev-server #13647

Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Dec 5, 2022

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 8:53PM (UTC)

@jaysoo jaysoo force-pushed the feat/default-hmr-true-for-vite-dev-server branch from 1c4e1a6 to 2265e5f Compare December 5, 2022 20:47
Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@FrozenPandaz FrozenPandaz merged commit 8a74e62 into nrwl:master Dec 5, 2022
@mandarini
Copy link
Member

I think that if we set the value as default in schema.json, then whatever value you set in vite.config.ts is not going to be taken into account. I would set the value as true in vite.config.ts

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants