Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): pass nxext options to our executor #13587

Merged
merged 1 commit into from Dec 2, 2022

Conversation

mandarini
Copy link
Member

If some options are set to the executor for a nxext/vite, pass them to ours with the generator!

@mandarini mandarini self-assigned this Dec 2, 2022
@vercel
Copy link

vercel bot commented Dec 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 2, 2022 at 2:59PM (UTC)

@mandarini mandarini requested a review from jaysoo December 2, 2022 14:49
@nx-cloud
Copy link

nx-cloud bot commented Dec 2, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7c07af1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx affected --target=e2e --base=3180427b8a48a772bb1598e649fc1d692f7a55a4 --head=3ce4391cb80b5ee5ce87cb2ee723829556baeaac --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox --parallel=1
✅ Successfully ran 21 targets

Sent with 💌 from NxCloud.

@mandarini mandarini merged commit d5f834a into nrwl:master Dec 2, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants