Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): ensure apps/libs layout is created when migrating from angular cli to nx monorepo layout #13577

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Dec 2, 2022

Current Behavior

Migrating from an Angular CLI workspace to an Nx workspace with a monorepo layout breaks for e2e projects due to changes in the workspace layout handling.

Expected Behavior

Migrating from an Angular CLI workspace to an Nx workspace with a monorepo layout should work correctly.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Dec 2, 2022
@vercel
Copy link

vercel bot commented Dec 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 2, 2022 at 11:52AM (UTC)

@leosvelperez leosvelperez marked this pull request as ready for review December 2, 2022 12:58
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leosvelperez leosvelperez merged commit 2dd2eea into nrwl:master Dec 2, 2022
@leosvelperez leosvelperez deleted the angular/fix-ng-add-e2e-apps-dir branch December 2, 2022 14:10
Coly010 pushed a commit to Coly010/nx that referenced this pull request Dec 2, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants